Refactors #192
Merged
Refactors #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that it does not hold that HtmlContext::default() == config::plain().make_context() but the relevant fields used by fn parse_with_context() are the same. This is a bit unclear, this change makes this more obvious.
sftse
force-pushed
the
refactors
branch
2 times, most recently
from
01dd84e to
edfd1a0
Compare
|
I'm sorry it's going to take me longer to review this - since you have force-pushed I can't see a way to easily compare just the changes since I reviewed it before, and as it's been a little while with the holidays I'll have to review it all again. |
|
Yes, that was unfortunate. Will keep in mind for the future. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the non-behavior-changing modifications from #191
The original motivation for these changes is to streamline the way the library calls itself internally. We observed some slight mismatches between how the public API exposes the configurable stages and how the library passes information internally. We investigated whether those mismatches were a bug, but thankfully they were not. Still, the changes we suggest make this clearer by using higher-level functions where possible.